feat: sync CLI with dashboard@v1.6.6 - #69
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Sync CLI with dashboard@v1.6.6. The v1.6.6 dashboard release is a redeploy of v1.6.5 with no new code changes (same commit, 69f7b6e6bdfb0a9fd72ee94f278c6ccc82956b0c), so the published @photon-ai/dashboard-api contract is unchanged from the last sync attempts, but main is still pinned to 1.2.0. Bump to the latest published (1.6.1) so this release actually reaches users. Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.x @photon-ai/dashboard-api bundle types every response body as Record<string, any>, so Array.prototype.map callbacks no longer get an inferred element type. Introduce Project and SpectrumUser DTOs in src/lib/types.ts and cast at the API boundary (projects.ts list command and spectrum/users.ts list command), matching the AGENTS.md soft rule that new DTOs live in types.ts. Hoists the previously local SpectrumUser interface into the shared module so the add-user handler can share the shape. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean, minimal sync PR — one version bump plus the exact boundary-cast fix the 1.6.x `Record<string, any>` response typing forced. Ready for human merge. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
@photon-ai/dashboard-apidevDep1.2.0→1.6.1(latest published; still what dashboard@v1.6.6 ships, since v1.6.6 is a same-commit redeploy of v1.6.5 with no api-public change)Routes added/removed/changed
No API contract change from v1.6.5 → v1.6.6 (redeploy). Relative to the CLI's previously-pinned
@photon-ai/dashboard-api@1.2.0, the accumulated deltas fromUPSTREAM_DIFF.mdare:Added (23) — none wired into CLI commands yet:
projects/:id/membersGET/POST +projects/:id/members/:memberUserIdDELETEprojects/:id/slackGET/PUT/DELETE +projects/:id/slack/installationsGET +projects/:id/slack/installations/:teamIdDELETEprojects/:id/spectrum/avatarDELETE +projects/:id/spectrum/avatar/uploadPOST +projects/:id/spectrum/avatar/commitPOSTprojects/:id/voice/imessage-enabledPATCH +projects/:id/voice/settingsGET +projects/:id/voice/sip-inboundPATCH/DELETEprojects/:id/webhooksGET/POST +projects/:id/webhooks/:webhookIdDELETEprojects/:id/whatsapp/templatesGET/POST +projects/:id/whatsapp/templates/:templateIdPATCH/DELETEprofile/spectrum-updatesPATCHRemoved (1):
projects/:id/spectrum/avatar-upload-urlGET (not consumed by any existing CLI command)Changed: none.
Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNotes
The 1.6.x
@photon-ai/dashboard-apibundled.d.tstypes every route response body asRecord<string, any>(index-signature only). Dot access still compiles, butArray.prototype.mapcallbacks lose their element type (TS7006). Fixed at the API boundary by introducing typedProjectandSpectrumUserDTOs insrc/lib/types.tsand castingdata/data.usersin the two affected list commands (projects.ts,spectrum/users.ts). The previously-localSpectrumUserinterface is hoisted into the shared module so the add-user handler shares the shape.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.