Fix config path bug#147
Conversation
Updated paths for config.guess and config.sub files.
Updated the paths for config.guess and config.sub files.
|
|
||
| ## Replace config.guess and config.sub | ||
| cp ../archives/config.guess ../archives/config.sub ${BINUTILS} | ||
| cp ../config/config.guess ../config/config.sub ${BINUTILS} |
There was a problem hiding this comment.
This is not correct. The get-config-scripts.sh script tries to fetch config.guess and config.sub from Savannah and place them in the current working directory. Only if it fails will it copy the files from config to the current working directory. Your change makes this script use the version from config even if a newer version was successfully downloaded from Savannah.
One could argue that the download from Savannah should be removed completely, but performing the download and then not using the result just seems wrong...
There was a problem hiding this comment.
I think the disconnect comes from where this was carried over from ps3libraries. In ps3libraries, get-config-scripts.sh downloads (or copies) config.guess and config.sub into archives, where the script can then find them. Here, get-config-scripts.sh instead downloads (or copies) them to the current directory.
There was a problem hiding this comment.
oh, I see. Sorry for my mistake. I'm going to open a new PR with a proper fix based on your feedback. 👍
2 participants
No description provided.