Skip to content

fix(runtime): use upstream WHATWG URL parser #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
Jul 25, 2026
Merged

fix(runtime): use upstream WHATWG URL parser #1851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/native-sidecar/src/execution/javascript/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use crate::state::DeferredRpcError;
const HTTP_LOOPBACK_REQUEST_TIMEOUT: Duration = Duration::from_secs(30);
const VM_FETCH_STREAM_CHUNK_MAX_BYTES: usize = 64 * 1024;
const VM_FETCH_STREAM_COUNT_LIMIT: usize = 256;
type VmFetchResponseHead = (u16, String, Vec<(String, String)>, VmFetchBodyMode);

fn http_loopback_request_timeout() -> Duration {
std::env::var(HTTP_LOOPBACK_REQUEST_TIMEOUT_MS_ENV)
Expand Down Expand Up @@ -272,7 +273,7 @@ fn parse_stream_response_head(
bytes: &[u8],
request_method: &str,
max_response_bytes: usize,
) -> Result<(u16, String, Vec<(String, String)>, VmFetchBodyMode), SidecarError> {
) -> Result<VmFetchResponseHead, SidecarError> {
let text = std::str::from_utf8(bytes).map_err(|error| {
SidecarError::Execution(format!(
"ERR_AGENTOS_VM_FETCH_INVALID_RESPONSE: response headers were not UTF-8: {error}"
Expand Down
36 changes: 0 additions & 36 deletions packages/build-tools/bridge-src/builtins/url-resolution.ts
View file
Open in desktop

This file was deleted.

Loading
Loading