feat: add offline network indicator and popup on download screen (#651)#652
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for the issue and the PR, @prince-0408 :) Could you fix the Ktlint and Detekt issues? |
Done |
c5d3f31 to
e067939
Compare
e067939 to
2435548
Compare
|
Feel free to merge this once the tests pass, @angrezichatterbox :) Thanks for your efforts here, @prince-0408! |
|
note: We're reverting the clipboard key setting given a new direction for the UI that we'll be doing in #655 :) |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's working really well here, @prince-0408! Really great to have this in, which also helped us close the Scribe-i18n issue for the Scribe-Server strings 😊
Related Issue
Closes #651
Description
This PR addresses the issue where interacting with download actions while offline would fail silently. It introduces a proactive network check to ensure users receive clear feedback if they try to download or update data without an active internet connection.
Changes Included:
NetworkMonitor.kt: Added a new utility to observe and verify the device's internet connection status using Android'sConnectivityManager.DataDownloadViewModel.kt&ConjugateDataDownloadViewModel.kt: Intercepted download and update events to verify network availability before proceeding.App.kt: Initialized or hooked up any necessary application-level network monitoring dependencies.Screenshots