Skip to content

feat: add offline network indicator and popup on download screen (#651)#652

Merged
andrewtavis merged 9 commits into
scribe-org:mainfrom
prince-0408:feature/offline-network-indicator
Jul 12, 2026
Merged

feat: add offline network indicator and popup on download screen (#651)#652
andrewtavis merged 9 commits into
scribe-org:mainfrom
prince-0408:feature/offline-network-indicator

Conversation

@prince-0408

Copy link
Copy Markdown
Contributor

Related Issue

Closes #651

Description

This PR addresses the issue where interacting with download actions while offline would fail silently. It introduces a proactive network check to ensure users receive clear feedback if they try to download or update data without an active internet connection.

Changes Included:

  • NetworkMonitor.kt: Added a new utility to observe and verify the device's internet connection status using Android's ConnectivityManager.
  • DataDownloadViewModel.kt & ConjugateDataDownloadViewModel.kt: Intercepted download and update events to verify network availability before proceeding.
  • UI Feedback: Integrated a popup/Snackbar to display the message "No internet connection. Please connect and try again." if the user is offline.
  • App.kt: Initialized or hooked up any necessary application-level network monitoring dependencies.

Screenshots

Offline Warning Popup Network Connected
offline  network connected

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

Thanks for the issue and the PR, @prince-0408 :) Could you fix the Ktlint and Detekt issues?

@andrewtavis andrewtavis added the -next release- Included in the next release label Jul 11, 2026
@prince-0408

prince-0408 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the issue and the PR, @prince-0408 :) Could you fix the Ktlint and Detekt issues?

Done
@andrewtavis

@angrezichatterbox
angrezichatterbox force-pushed the feature/offline-network-indicator branch from c5d3f31 to e067939 Compare July 12, 2026 15:43
@angrezichatterbox
angrezichatterbox force-pushed the feature/offline-network-indicator branch from e067939 to 2435548 Compare July 12, 2026 15:45
@andrewtavis

Copy link
Copy Markdown
Member

Feel free to merge this once the tests pass, @angrezichatterbox :)

Thanks for your efforts here, @prince-0408!

@andrewtavis

Copy link
Copy Markdown
Member

note: We're reverting the clipboard key setting given a new direction for the UI that we'll be doing in #655 :)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's working really well here, @prince-0408! Really great to have this in, which also helped us close the Scribe-i18n issue for the Scribe-Server strings 😊

@andrewtavis
andrewtavis merged commit 3f56883 into scribe-org:main Jul 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-next release- Included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add offline network indicator and popup on download screen

3 participants