Skip to content

Collapse a redirect double-hop; audit legacy redirects (#650)#1078

Merged
ionous merged 2 commits into
shift-org:mainfrom
dduugg:issue-650-redirect-cleanup
Jul 10, 2026
Merged

Collapse a redirect double-hop; audit legacy redirects (#650)#1078
ionous merged 2 commits into
shift-org:mainfrom
dduugg:issue-650-redirect-cleanup

Conversation

@dduugg

@dduugg dduugg commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Addresses #650 (audit + trim legacy redirects in netlify.toml and nginx).

On audit, almost everything flagged as potential "legacy cruft" turns out to still be load-bearing, so this is a deliberately small change. Details below so a maintainer can decide whether a more aggressive prune is worth the risk of breaking old inbound links.

Change

Collapse the /calendar/pedalpalooza redirect double-hop. It pointed at /pages/pedalpalooza, which is itself only a redirect to /pages/bike-summer, so this now points straight at /pages/bike-summer (one fewer 301 round-trip; no user-facing link breaks; destination page confirmed present).

Audit

nginx (services/nginx/conf.d/shift.conf) - nothing to remove

The issue asks specifically about /legacy or /backend details. There are no /legacy or /backend redirects. The only /opt/backend/eventimages references are the live event-image storage path, and every proxy_pass targets a current endpoint. (The /api/*.php URLs remain the real API paths even after the PHP source was removed in #694.)

netlify.toml - kept, with rationale

Everything else is still serving a purpose, so removing it would regress rather than clean up:

  • Domain canonicalization (shift2bikes.com, shifttobikes.org, ... -> www.shift2bikes.org): alternate domains still resolve here.
  • Backend/proxy (/api/*, /eventimages/*, /socialapi/): live functionality.
  • iCal feeds (/cal/icalpp.php, /cal/pedalpalooza-calendar.php, /cal/shift-calendar.php): in use; icalpp.php is explicitly annotated as a years-old feed people still rely on.
  • Legacy links (/cal/*, /pedalpalooza, /pages/pedalpalooza, /pedalpalooza-calendar, /wiki/shift-shop:rack-rental, /pages/playbooks): these exist precisely to preserve old inbound links (some from offsite pages we can't edit, e.g. PBoT). Removing them 404s those links. All redirect targets were verified to still exist (bike-summer, bike-summer-calendar, bike-racks, meeting-notes).
  • SPA handlers (/addevent/*, /calendar/*, /events/*) and the Android PWA /.well-known/assetlinks.json: live routing.

Deliberately left alone

Verification

netlify.toml is Netlify infrastructure config with no local test path; verified by inspection, and the destination (site/content/pages/bike-summer.md) exists. nginx is unchanged.

Comment thread netlify.toml Outdated
@ionous

ionous commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

that's some good archaeology! ( and i was able to confirm that we've received requests to icalpp.php, pedalpalooza-calendar.php, and shift-calendar.php! )

i think the socialapi is from an old experiment of pulling in bike-summer mastodon posts into the calendar feed. it's outside of the scope of this issue, but we should probably yank the code and then the route at some point.

@ionous ionous merged commit 2d03236 into shift-org:main Jul 10, 2026
4 checks passed
@dduugg dduugg deleted the issue-650-redirect-cleanup branch July 10, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants