Collapse a redirect double-hop; audit legacy redirects (#650)#1078
Merged
Conversation
dduugg
commented
Jul 1, 2026
carrythebanner
approved these changes
Jul 9, 2026
Contributor
|
that's some good archaeology! ( and i was able to confirm that we've received requests to icalpp.php, pedalpalooza-calendar.php, and shift-calendar.php! ) i think the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #650 (audit + trim legacy redirects in
netlify.tomland nginx).On audit, almost everything flagged as potential "legacy cruft" turns out to still be load-bearing, so this is a deliberately small change. Details below so a maintainer can decide whether a more aggressive prune is worth the risk of breaking old inbound links.
Change
Collapse the
/calendar/pedalpaloozaredirect double-hop. It pointed at/pages/pedalpalooza, which is itself only a redirect to/pages/bike-summer, so this now points straight at/pages/bike-summer(one fewer 301 round-trip; no user-facing link breaks; destination page confirmed present).Audit
nginx (
services/nginx/conf.d/shift.conf) - nothing to removeThe issue asks specifically about
/legacyor/backenddetails. There are no/legacyor/backendredirects. The only/opt/backend/eventimagesreferences are the live event-image storage path, and everyproxy_passtargets a current endpoint. (The/api/*.phpURLs remain the real API paths even after the PHP source was removed in #694.)netlify.toml - kept, with rationale
Everything else is still serving a purpose, so removing it would regress rather than clean up:
shift2bikes.com,shifttobikes.org, ... ->www.shift2bikes.org): alternate domains still resolve here./api/*,/eventimages/*,/socialapi/): live functionality./cal/icalpp.php,/cal/pedalpalooza-calendar.php,/cal/shift-calendar.php): in use;icalpp.phpis explicitly annotated as a years-old feed people still rely on./cal/*,/pedalpalooza,/pages/pedalpalooza,/pedalpalooza-calendar,/wiki/shift-shop:rack-rental,/pages/playbooks): these exist precisely to preserve old inbound links (some from offsite pages we can't edit, e.g. PBoT). Removing them 404s those links. All redirect targets were verified to still exist (bike-summer,bike-summer-calendar,bike-racks,meeting-notes)./addevent/*,/calendar/*,/events/*) and the Android PWA/.well-known/assetlinks.json: live routing.Deliberately left alone
/campaign1->/is a sample/placeholder campaign redirect. It is a removal candidate, but PR theoretical redirect for special campaign urls #1056 is actively reworking campaign redirects, so it is left to avoid conflict.Verification
netlify.tomlis Netlify infrastructure config with no local test path; verified by inspection, and the destination (site/content/pages/bike-summer.md) exists. nginx is unchanged.