chore: tidy Trainer.train loop + drop __main__ dead code#44
Merged
Conversation
No behavior change: collapse the draw/get_merges steps in the training loop, drop stray blank lines, and remove the commented-out example_sentence /other_graph scratch in the __main__ block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure cleanup, no behavior change — extracted from the incremental-counting PR (#42) so that one stays focused on the speed change.
get_mergessteps in the recount loop and drop stray blank lines.create_gif(...).show().example_sentence/other_graphscratch in the__main__block.Tests pass; output unchanged.
🤖 Generated with Claude Code