Skip to content

chore: tidy Trainer.train loop + drop __main__ dead code #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmitMY merged 1 commit into from
Jun 28, 2026
Merged

chore: tidy Trainer.train loop + drop __main__ dead code #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions complex_tokenization/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,27 +26,21 @@ def __init__(self, graph: GraphVertex | None = None, graphs: tuple[GraphVertex,
self.merges = []

def train(self, num_merges: int = 100, draw=False, verbose=False, progress=False):
frames = []

remaining = range(len(self.merges), num_merges)
if progress:
from tqdm import tqdm
remaining = tqdm(remaining, desc="Training", initial=len(self.merges), total=num_merges)

frames = []
for _ in remaining:

if draw:
dot_content = "\n".join(self.graph.dot())
image = draw_dot_content(dot_content)
frames.append(image)
frames.append(draw_dot_content("\n".join(self.graph.dot())))

counts = Counter(self.graph.get_merges())

if not counts:
break

nodes = max(counts.items(), key=_merge_score)[0]

if verbose:
print("Merging", nodes, "count=", counts[nodes])
token = reduce(lambda x, y: x + y, nodes)
Expand All @@ -55,8 +49,7 @@ def train(self, num_merges: int = 100, draw=False, verbose=False, progress=False
self.merges.append((token, nodes))

if draw:
gif = create_gif(frames, save="example.gif")
gif.show()
create_gif(frames, save="example.gif").show()

def get_merges(self):
return [tuple(str(node) for node in nodes) for _, nodes in self.merges]
Expand All @@ -70,12 +63,5 @@ def get_merges(self):
utf8("头"),
)),
))
# example_sentence = "the teacher teaches the thick."
example_sentence = "test test"
# example_graph = sentence_to_graph(example_sentence)

# other_graph = words(example_sentence)
# example_graph = NodesSequence((example_graph, utf8(" "), other_graph))

trainer = Trainer(graph=example_graph)
trainer.train(num_merges=10, draw=True)
Loading