Add integer parsing error-path test coverage#465
Merged
Conversation
Covers the InvalidNumber paths in parse_number that were previously untested: leading zeroes, base prefixes (0x/0b/0o), a bare/invalid sign, integers with an exponent marker but no exponent digits, and non-terminator trailing bytes. Addresses simd-lite#89.
Licenser
approved these changes
Jul 13, 2026
Licenser
left a comment
Licenser
left a comment
Member
There was a problem hiding this comment.
Nice! I like it more tests are more better!
Member
|
If you want to add the same to the apron parsing 👍 happy to merge another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for integer parse errors, see #89.
parse_numberhad solid happy-path coverage but most of itsInvalidNumberbranches were untested. Added tests for:01,-010x1,0b1,0o1-not followed by a digit —-,-x1e,1e+123a,1_000Test-only, no parser changes. Covers the default (
correct.rs) path; happy to mirror the same into theapprox-number-parsingpath too if you'd prefer.