Integrate PR 88#91
Merged
Merged
Conversation
Refactor logString to use snprintf for better performance and avoid heap fragmentation.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors UDPLogger::logString to reduce String copying/concatenation and instead format log output into a fixed-size buffer, aiming to improve runtime efficiency and reduce heap fragmentation on ESP8266.
Changes:
- Updates
UDPLogger::logStringto takeconst String&instead of copying the argument. - Replaces
Stringconcatenation +toCharArraywithsnprintfinto_packetBufferand prints/sends that buffer. - Minor formatting/cleanup in
udplogger.cpp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| udplogger.h | Updates logString declaration to take const String& for fewer copies. |
| udplogger.cpp | Implements fixed-buffer formatting for logString and updates the signature accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the PR #88