chore(release-prep): invoke-arg test coverage + clean clippy#54
Conversation
Add a smoke test over cshell's own invoke path — `prepare_invocation` → `load_args` → `into_resolve_request` — on the `05-invoke` arg surface: a record `meta` nesting a `List<Int>` plus Int/ Bool/Bytes scalars. Asserts the record serializes to the tagged wire form (fields positional in declared order) and scalars stay bare. The SDK already covers the encoder; this pins cshell's glue (JSON-string parsing, tii load, the args→resolve-request hand-off) that the SDK tests skip. Adds a staged `tests/fixtures/invoke.tii`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 29 minutes and 58 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Release-prep for the next cshell cut: adds invoke-path test coverage and clears the pre-existing clippy debt so CI (
cargo clippy -- -D warnings) goes green.1. Invoke-arg test coverage
A smoke test over cshell's own invoke glue —
prepare_invocation→load_args→into_resolve_request— on the05-invokearg surface (recordmetanestingList<Int>, plus Int/Bool/Bytes scalars):metaserializes to the taggedTaggedArgstructwith fields in declared order (tags,level);The SDK already covers the encoder; this pins the glue cshell owns (args-JSON parsing,
.tiiload, args → resolve hand-off) that the SDK tests skip. Stagedtests/fixtures/invoke.tii.2. Clean clippy for green CI
cargo clippy -- -D warningswas failing on pre-existing warnings. Fixes (no behavior change):UTxORPCParametersstruct (and its orphaned serde import);ifs into match guards in the explorer key handlers (catch-all is a no-op_ => {}, so behavior is identical);Ok(..?).Verification
cargo clippy -- -D warningsclean;cargo clippy --all-targetsclean.cargo testgreen (7).🤖 Generated with Claude Code