Skip to content

chore(release-prep): invoke-arg test coverage + clean clippy#54

Merged
scarmuega merged 1 commit into
mainfrom
test/invoke-arg-coverage
Jun 22, 2026
Merged

chore(release-prep): invoke-arg test coverage + clean clippy#54
scarmuega merged 1 commit into
mainfrom
test/invoke-arg-coverage

Conversation

@scarmuega

@scarmuega scarmuega commented Jun 22, 2026

Copy link
Copy Markdown
Member

Release-prep for the next cshell cut: adds invoke-path test coverage and clears the pre-existing clippy debt so CI (cargo clippy -- -D warnings) goes green.

1. Invoke-arg test coverage

A smoke test over cshell's own invoke glue — prepare_invocationload_argsinto_resolve_request — on the 05-invoke arg surface (record meta nesting List<Int>, plus Int/Bool/Bytes scalars):

  • meta serializes to the tagged TaggedArg struct with fields in declared order (tags, level);
  • scalars stay bare.

The SDK already covers the encoder; this pins the glue cshell owns (args-JSON parsing, .tii load, args → resolve hand-off) that the SDK tests skip. Staged tests/fixtures/invoke.tii.

2. Clean clippy for green CI

cargo clippy -- -D warnings was failing on pre-existing warnings. Fixes (no behavior change):

  • drop unused imports + the never-constructed UTxORPCParameters struct (and its orphaned serde import);
  • collapse inner ifs into match guards in the explorer key handlers (catch-all is a no-op _ => {}, so behavior is identical);
  • redundant closure → method reference; drop a needless Ok(..?).

Verification

  • cargo clippy -- -D warnings clean; cargo clippy --all-targets clean.
  • cargo test green (7).

🤖 Generated with Claude Code

Add a smoke test over cshell's own invoke path —
`prepare_invocation` → `load_args` → `into_resolve_request` — on the
`05-invoke` arg surface: a record `meta` nesting a `List<Int>` plus Int/
Bool/Bytes scalars. Asserts the record serializes to the tagged wire
form (fields positional in declared order) and scalars stay bare.

The SDK already covers the encoder; this pins cshell's glue (JSON-string
parsing, tii load, the args→resolve-request hand-off) that the SDK tests
skip. Adds a staged `tests/fixtures/invoke.tii`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@scarmuega, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 58 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0ad1572-6a66-447a-ac17-40fcccb178b5

📥 Commits

Reviewing files that changed from the base of the PR and between c048f84 and d52adb4.

📒 Files selected for processing (2)
  • src/tx/common.rs
  • tests/fixtures/invoke.tii
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/invoke-arg-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit 2940081 into main Jun 22, 2026
9 of 10 checks passed
@scarmuega scarmuega deleted the test/invoke-arg-coverage branch June 22, 2026 19:57
@scarmuega scarmuega changed the title test(invoke): cover arg encoding through the invoke glue chore(release-prep): invoke-arg test coverage + clean clippy Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant